feat(thru): Make thru parametric in its return type #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This does looks good, thanks for the quick update! |
|
lgtm 👍 |
cloderic
added a commit
to craft-ai/most-utils
that referenced
this pull request
Aug 11, 2017
- It's one of the output of cujojs/most#471. - Needs the integration of cujojs/most#473 for typescript to figure it out.
|
🚢 🇮🇹 |
|
Thanks for the reviews! We'll get this released soon. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #471
Make
thruparametric in its return type to admit functions that return something other than a Stream.Todo