add pipx plugin #28
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||||||||||||||||||
| { | ||||||||||||||||||||||
| "name": "pipx", | ||||||||||||||||||||||
| "version": "0.1.0", | ||||||||||||||||||||||
| "description": "Installs Pipx and makes it available", | ||||||||||||||||||||||
| "packages": ["pipx@latest"], | ||||||||||||||||||||||
| "env": { | ||||||||||||||||||||||
| "PIPX_HOME": "{{ .Virtenv }}", | ||||||||||||||||||||||
| "PIPX_BIN_DIR": "{{ .Virtenv }}/bin" | ||||||||||||||||||||||
| }, | ||||||||||||||||||||||
| "shell": { | ||||||||||||||||||||||
| "init_hook": [ | ||||||||||||||||||||||
| "export PATH=\"{{ .Virtenv }}/bin:$PATH\"" | ||||||||||||||||||||||
| ] | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
Comment on lines
+8
to
+14
There was a problem hiding this comment. [suggestion]: you can update the path without an
Suggested change
There was a problem hiding this comment. I think I already tried this – you can see that I changed it here when pulling out the local versions of the plugins. This was presumably because something didn't work with setting in the path directly (but this is what I was doing before using plugins). I can't remember what didn't work though... There was a problem hiding this comment. @jay-aye-see-kay ☝️ I just checked, and I can confirm that it doesn't get added to path by direct manipulation when the app's There was a problem hiding this comment. Oh gross, I hadn't seen that issue before - IMO that's a bug in devbox, I'll make some time this week to raise that with them. That's likely an issue for some of the built in plugins, i.e. the ruby plugin uses this approach https://github.com/jetify-com/devbox/blob/main/plugins/ruby.json Let's leave it as is, it works and there's no downside the the There was a problem hiding this comment. Bug report here: jetify-com/devbox#2138 |
||||||||||||||||||||||
| } | ||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be our first plugin that includes a package, up until a few months ago devbox plugins only supported config.
I think this is a good use case for bundling a package in a plugin, but just keep an eye out for surprising behaviour - i.e. I'm not sure how the version of
pipxis set and updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes good call. I think it might make sense to at least pin to a pipx version so that it's repeatable (my guess would be otherwise this is resolved at the app level meaning you could run it twice with different results as it stands although presumably the app's devbox.lock would make it a little more repeatable at least)