Key-value log passes correctness tests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: This PR brings us very close to closing #20 |
|
Looks good to me. Associated constants have landed in stable 1.20, so there's no reason not to use them. You can even define a default parameter for traits, as described here: rust-lang/reference#24 It looks like we're close to pushing our work into master. You'll have to show me how to make a overview issue to handle that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel fairly confident that the key value log is now implemented correctly, and would like to land this module into the
devandmasterbranches, ideally. I'll start with this PR fordev.Some things still to figure out: The "right way" for the code to choose these constants
CHUNK_BITSandCHUNK_BITC. Ideally, we'd use associated constants of a (currently non-existent) type parameter, to impose zero runtime overhead for storing these constants in the data structure itself.