Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag slow test as a smoke_test #2178

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Flag slow test as a smoke_test #2178

merged 1 commit into from
Oct 10, 2021

Conversation

mark-dce
Copy link
Contributor

This test doesn't test any code that isn't tested elsewhere,
it just tests it more times by runing the full production config file
that sets up 21 admin sets - i.e. it runs the same tests 21 times.

While it's somewhat useful to know that all currently configured
admin sets in config/emory/admin_sets.yml are setup correctly, that
can be manually verified in the dashboard on the page at
https://etd.library.emory.edu/schools

Long term, this check probably belongs in some kind of deployment check
rather than the main test suite.

This test doesn't test any code that isn't tested elsewhere,
it just tests it more times by runing the full production config file
that sets up 21 admin sets - i.e. it runs the same tests 21 times.

While it's somewhat useful to know that all currently configured
admin sets in config/emory/admin_sets.yml are setup correctly, that
can be manually verified in the dashboard on the page at
https://etd.library.emory.edu/schools

Long term, this check probably belongs in some kind of deployment check
rather than the main test suite.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.119% when pulling b0b7684 on slow_test into b85fa17 on main.

@mark-dce
Copy link
Contributor Author

I'm merging this since coveralls reports no change in coverage and it speeds up the test suite.

@mark-dce mark-dce merged commit bd4b3b0 into main Oct 10, 2021
@mark-dce mark-dce deleted the slow_test branch October 10, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants