Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional embargo testing #2190

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Add additional embargo testing #2190

merged 1 commit into from
Oct 15, 2021

Conversation

mark-dce
Copy link
Contributor

Only one other test caught breaking permissions changes when the
GraduationJob was refactored. This adds more explicit testing in
hopes of making the desired user-facing behavior more explicit.

After Graduation, embargoed works:

  • Should be discoverable (published, active, not suppressed)
  • Should restrict access to ETD files (filesets restricted)
  • Should have an release date the requested embargo_length after graduation
    [New Tests]
  • Should be displayable (open from an access control perspective)
  • Should show an embargo badge (*_restricted visibility - all, toc, or files)

Only one other test caught breaking permissions changes when the
GraduationJob was refactored. This adds more explicit testing in
hopes of making the desired user-facing behavior more explicit.

After Graduation, embargoed works:
* Should be discoverable (published, active, not suppressed)
* Should restrict access to ETD files (filesets restricted)
* Should have an release date the requested embargo_length after graduation
[New Tests]
* Should be displayable (open from an access control perspective)
* Should show an embargo badge (*_restricted visibility - all, toc, or files)
@coveralls
Copy link

Coverage Status

Coverage increased (+2.9%) to 92.081% when pulling 92b337b on postgrad_embargo into e536a99 on main.

@mark-dce mark-dce merged commit 2460d30 into main Oct 15, 2021
@mark-dce mark-dce deleted the postgrad_embargo branch October 15, 2021 15:45
@mark-dce mark-dce mentioned this pull request Sep 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants