[CSR-2001] fix: ensure date values are properly handled #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vCaisim
commented
Dec 30, 2024
| wallClockEndedAt: endTime.toISOString(), | ||
| wallClockDuration: durationMillis, | ||
| }, | ||
| tests: testcases?.map((test) => { | ||
| accTestTime += timeToMilliseconds(testcases[0]?.time); | ||
| if (testcases[0]?.time) { |
There was a problem hiding this comment.
@miguelangaranocurrents please confirm that this is working as expected.
There was a problem hiding this comment.
Yes, it is working as expected
vCaisim
commented
Dec 30, 2024
| return 0; | ||
| export function getTimestampValue(dateString: string) { | ||
| if (!isValidDate(dateString)) { | ||
| return new Date().getTime(); |
There was a problem hiding this comment.
return current timestamp instead of 0 if the date string is not a valid date
vCaisim
commented
Dec 30, 2024
| const testcases = ensureArray<TestCase>(suite.testcase); | ||
|
|
||
| let accTestTime = 0; | ||
|
|
||
| const passes = testcases.filter( | ||
| (tc) => (tc.failure ?? []).length === 0 |
There was a problem hiding this comment.
failure is of type (string | Failue)[] | undefined
miguelangaranocurrents
approved these changes
Dec 31, 2024
ynahmany
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.