Align trampoline to nearest 16 bytes to prevent crash #78
Conversation
|
Never mind it seems like it was memory corruption caused by something else which this randomly happened to bypass. However I've read that it is recommended to align jumps to 16 bytes for speed purposes so maybe this is still worth doing? |
I'm unsure about the 16-byte alignment stuff (I assume CPU will fetch up to a cache line anyway), but your changes here are making the CI checks fail, somehow. Those will have to be fixed before a review happens. |
|
Why is PR closed? I think the problem is still relevant - shqke/sourcetvsupport#48 |
If someone has a nice way to test this and can make a PR which passes CI, then a PR can be opened and reviewed. I personally don’t have a way to test this (I primarily target x86-64 Windows and didn’t have much issue with 32-bit in the past, but I’m unsure of linux). Seems like the original PR creator closed it. If you have more details or a way to reproduce it, that’ll be great! |
Not having the trampoline aligned by 16 bytes seems to cause random crashes/memory corruption on 32bit. I did not run into any weird issues like this on 64bits with a bunch of hooks strangely.
I was trying to figure out why it was crashing and after staring at the assembly for an entire day, I finally thought about alignment. The 2 hooks I was having problems with had trampoline sizes of 15 bytes.