Use C++ style casts

[CrackedMatter]

No description provided.

[angelfor3v3r]

The casts inside align_up and align_down won't work this way, could you change them so the checks pass? I believe special care must be taken when T is a pointer vs some integer type.

[angelfor3v3r]

Thanks! LGTM!

[A1mDev]

https://github.com/alliedmodders/sourcemod/actions/runs/12385271125/job/34571228199 - It seems these changes are not being compiled on clang

[angelfor3v3r]

https://github.com/alliedmodders/sourcemod/actions/runs/12385271125/job/34571228199 - It seems these changes are not being compiled on clang

Could it be because of clang 8? It seems like some concepts were introduced with clang 10 & clang 16.

[A1mDev]

It seems because of stdc++17 =(

[angelfor3v3r]

It seems because of stdc++17 =(

Makes sense. We develop for C++23 but there is some polyfills for C++20 (not sure how well it works, I never tried it):

safetyhook/amalgamate.py

Line 25 in 60bdee3

parser.add_argument('--polyfill', action='store_true',

[A1mDev]

Everything compiles fine except for this code - https://github.com/cursey/safetyhook/blob/main/include/safetyhook/utility.hpp#L17-L26

[angelfor3v3r]

Everything compiles fine except for this code - https://github.com/cursey/safetyhook/blob/main/include/safetyhook/utility.hpp#L17-L26

It seems like concept expressions and auto arguments are both C++20 features. I'm not sure if there's goals to target C++17 or lower (granted, you will have to use polyfill mode anyway for C++20). See: #76

Edit: See reply below.

[cursey]

Everything compiles fine except for this code - https://github.com/cursey/safetyhook/blob/main/include/safetyhook/utility.hpp#L17-L26

I'm fine if you want to throw together a PR that simplifies the offending code to use C++17 features. If it's at least mostly equivalent in functionality I would be fine adopting it.

[angelfor3v3r]

Everything compiles fine except for this code - https://github.com/cursey/safetyhook/blob/main/include/safetyhook/utility.hpp#L17-L26

Can you give this a try?: #83