Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HMI brightness entity #136

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

sveinse
Copy link
Collaborator

@sveinse sveinse commented Oct 25, 2024

Adds support for setting the status light brightness.

Fixes #112

@sveinse
Copy link
Collaborator Author

sveinse commented Oct 25, 2024

@c0mplex1 this PR will introduce a new line translation-line. See the commit. What is the Dutch translation for the same line? I can update the PR with the Dutch translation as well.

@c0mplex1
Copy link
Contributor

c0mplex1 commented Oct 26, 2024

"hmi_brightness": { "name": "Helderheid statusindicator" }

Please change the following to a better Dutch translation ... or can/may I do this myself?

"installation_type": { "name": "Installatie type" },
"max_current": { "name": "Maximale stroom" },
"installation_type": { "name": "Installatie type" },
"max_current": { "name": "Max stroom per fase" },

"operating_mode": {
"name": "Operatie-modus",
"operating_mode": {
"name": "Opladermodus",

"deauthorize_and_stop": { "name": "Deautoriseer het laden"},
"restart_charger": { "name": "Herstart de oplader" },
"deauthorize_and_stop": { "name": "Deautoriseer het laden"},
"restart_charger": { "name": "Herstart het laadstation" },

@c0mplex1
Copy link
Contributor

I have made the changes in my "own" fork.
Do I need to create a new pull request?

@sveinse
Copy link
Collaborator Author

sveinse commented Oct 26, 2024

@c0mplex1 if there are more translations than just setting the HMI brightness translation, I'd prefer it in a separate PR please.

@sveinse sveinse merged commit ca56c83 into custom-components:master Oct 27, 2024
1 check passed
@sveinse sveinse deleted the feature-add-hmi-brightness branch October 27, 2024 10:40
@sveinse sveinse mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control brightness of status indicator
2 participants