Added support for chargers that are not reachable as installations #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hellowlol
reviewed
Apr 5, 2022
custom_components/zaptec/switch.py
Outdated
| @@ -17,13 +17,13 @@ async def async_setup_platform( | |||
| hass: HomeAssistantType, config: ConfigType, async_add_entities, discovery_info=None | |||
| ) -> bool: # pylint: disable=unused-argument | |||
| """Setup switch platform.""" | |||
| api = hass.data.get(DOMAIN, {}).get("api") | |||
| if api is None: | |||
| acc = hass.data[DOMAIN]["api"] | |||
There was a problem hiding this comment.
Use .get like I did before. This will raise and exception and not return None
|
Ok i’ll change that back. I changed it to this because In anorher file you did it this way
… 6 apr. 2022 kl. 01:23 skrev Steffen Fredriksen ***@***.***>:
@Hellowlol commented on this pull request.
In custom_components/zaptec/switch.py:
> @@ -17,13 +17,13 @@ async def async_setup_platform(
hass: HomeAssistantType, config: ConfigType, async_add_entities, discovery_info=None
) -> bool: # pylint: disable=unused-argument
"""Setup switch platform."""
- api = hass.data.get(DOMAIN, {}).get("api")
- if api is None:
+ acc = hass.data[DOMAIN]["api"]
Use .get like I did before. This will raise and exception and not return None
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
This is a great PR! I'll do some testing to make sure we didn't break anything for Zaptec home. |
|
Thanks :)
… 6 apr. 2022 kl. 21:07 skrev Steffen Fredriksen ***@***.***>:
This is a great PR! I'll do some testing to make sure we didn't break anything for Zaptec home.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
Any chance of getting this in a new release? I have tested the patch on our PRO-chargers and it works fine for me. |
|
I haven’t had time to test it yet. I’ll try to get it tested and released this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for PRO chargers that does not turn up as installations, and also removes some deprecation-warnings