Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concede #35

Closed
2 tasks
customcommander opened this issue Jan 2, 2022 · 1 comment
Closed
2 tasks

Remove concede #35

customcommander opened this issue Jan 2, 2022 · 1 comment
Labels
Milestone

Comments

@customcommander
Copy link
Owner

customcommander commented Jan 2, 2022

In retrospect I think this function is not useful at all and possibly harmful. Null pointer exceptions can happen with non-nil values. There's just no way we can prevent errors without involving a bunch of type checks and try/catch which wouldn't be in line with ADR 0004.

  • Mark as deprecated ASAP
  • Remove in v4
@customcommander customcommander added this to the v4.0.0 milestone Jan 2, 2022
customcommander added a commit that referenced this issue Jan 28, 2022
BREAKING CHANGE: the `concede` function is no longer available
github-actions bot pushed a commit that referenced this issue Jan 28, 2022
# [4.0.0](v3.3.0...v4.0.0) (2022-01-28)

### chore

* refactor `fallback` as an operator function. close [#38](#38) ([38c1bb0](38c1bb0))
* remove `concede`. close [#35](#35) ([30c75aa](30c75aa))
* remove support of strings as lists. close [#36](#36) ([1ae4b26](1ae4b26))

### BREAKING CHANGES

* the following functions no longer accept strings as lists: `all`, `any`, `drop`, `filter`, `into`, `map`, `none` and `take`.
* `fallback` is now an operator function.
* the `concede` function is no longer available
@customcommander
Copy link
Owner Author

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant