feat: public api for dismiss message #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
|
Build available to test |
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
============================================
+ Coverage 41.98% 42.00% +0.01%
Complexity 259 259
============================================
Files 99 99
Lines 2320 2319 -1
Branches 344 343 -1
============================================
Hits 974 974
+ Misses 1247 1246 -1
Partials 99 99 ☔ View full report in Codecov by Sentry. |
mrehan27
changed the title
mrehan27
changed the title
mrehan27
force-pushed
the
rehan/in-app-dismiss
branch
from
da65b77
to
e454484
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [4.1.0](4.0.1...4.1.0) (2024-08-09) ### Features * public api for dismiss message ([#420](#420)) ([8bfc37d](8bfc37d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since we decoupled all modules from
CustomerIOclass and moved them tocoremodule, modules were moved to theSDKComponentclass. This broke some public APIs accessed throughSDKComponentand made some of our documentation outdated (e.g., dismissing in-app messaging). To fix this, we had two options:Option 1 - Expose in-app module through
CustomerIOobject again.I think this is the most feasible option, so I opted for this.
Option 2 - Ask customers to use
SDKComponentinstead.I don't think recommending customers to use
SDKComponentis a very good idea, so I opted for option 1.Changes
CustomerIOobject for customer easeSDKComponentmethods exposing these modules as internalResources