Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: engine web changes and model changes #425

Merged

Conversation

Shahroz16
Copy link
Contributor

Second PR of the stack for the ticket: https://linear.app/customerio/issue/MBL-475/update-in-app-messaging-module-using-state-management-in-android

Changes:

  • Messages now are reliant on queue id
  • Engine web changes

Copy link

github-actions bot commented Aug 23, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: Build failed. See CI job logs to determine the issue and try re-building.
  • kotlin_compose: Build failed. See CI job logs to determine the issue and try re-building.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (79d8a6f) to head (e9ae2dc).
Report is 1 commits behind head on shahroz/in-app-refactor-stack-1.

Additional details and impacted files
@@                          Coverage Diff                           @@
##             shahroz/in-app-refactor-stack-1     #425       +/-   ##
======================================================================
- Coverage                              90.90%   61.63%   -29.28%     
- Complexity                                 0       35       +35     
======================================================================
  Files                                      1       16       +15     
  Lines                                     11      318      +307     
  Branches                                   2       44       +42     
======================================================================
+ Hits                                      10      196      +186     
- Misses                                     1      107      +106     
- Partials                                   0       15       +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Shahroz16 Shahroz16 merged commit eeb61a7 into shahroz/in-app-refactor-stack-1 Aug 26, 2024
15 of 32 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/in-app-refactor-stack-2 branch August 26, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants