Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Android native sample app name and icon #447

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

mahmoud-elmorabea
Copy link
Contributor

This PR just merged a feature branch with two approved PRs: #443 #445

The end result after updating the Android native sample app name and icon:
Screenshot 2024-09-30 at 12 52 18 PM Screenshot 2024-09-30 at 12 52 25 PM
Screenshot 2024-09-30 at 12 52 37 PM Screenshot 2024-09-30 at 12 52 50 PM

@mahmoud-elmorabea mahmoud-elmorabea self-assigned this Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: feature/native-sample-app-small-enhancement (1727690210)
  • kotlin_compose: feature/native-sample-app-small-enhancement (1727690201)

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.21%. Comparing base (8b30804) to head (7f77093).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #447      +/-   ##
============================================
+ Coverage     41.98%   51.21%   +9.22%     
- Complexity      259      287      +28     
============================================
  Files            99       95       -4     
  Lines          2320     2269      -51     
  Branches        344      353       +9     
============================================
+ Hits            974     1162     +188     
+ Misses         1247     1007     -240     
- Partials         99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

Build available to test
Version: feature-native-sample-app-small-enhancement-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@mahmoud-elmorabea mahmoud-elmorabea requested a review from a team September 30, 2024 10:08
@mahmoud-elmorabea mahmoud-elmorabea marked this pull request as ready for review September 30, 2024 10:08
@mahmoud-elmorabea mahmoud-elmorabea merged commit a8c84e3 into main Sep 30, 2024
40 checks passed
@mahmoud-elmorabea mahmoud-elmorabea deleted the feature/native-sample-app-small-enhancement branch September 30, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants