Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3rd party SDK compatibility when SDK forwards push events back to us #736

Merged
merged 4 commits into from
Jun 13, 2024

Commits on Jun 10, 2024

  1. fix: 3rd party SDK compatibility with showing push while app in foreg…

    …round
    
    Part of: https://linear.app/customerio/issue/MBL-364/[bug]-push-notifications-not-showing-while-app-in-foreground-on-ios
    
    The CIO SDK forwards push events to 3rd party SDKs. Some 3rd party SDKs send the push event back to the CIO SDK, potentially causing infinite loops. The SDK is designed to handle this. Previously, the responsibility of calling the completionHandler was on the 3rd party SDKs. However, some 3rd party SDKs delegate this responsibility back to us (See: https://linear.app/customerio/issue/MBL-364/[bug]-push-notifications-not-showing-while-app-in-foreground-on-ios#comment-3ae0db4e). This commit addresses that scenario.
    
    Testing:
    * Modified integration tests to cover this scenario.
    * Added tests for both `onPushAction` and `shouldDisplayPushAppInForeground` delegate functions.
    * Ran regression QA tests on iOS, RN, and Flutter.
    
    Notes for reviewers:
    - Limited comments in `iOSPushEventListener` intentionally. Test functions and comments in AutomaticPushClickIntegrationTest explain the use cases and reproducing steps.
    levibostian committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b2e0baa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bf5b4f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da7342b View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. get code to compile

    I cherry-picked the commit from the code targeting v2 branch. In v2, the logger instance is optional.
    levibostian committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    09f9dd7 View commit details
    Browse the repository at this point in the history