Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FirebaseMessaging Dependency in v2 Branch for Compatibility with New Firebase Versions #824

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

AristideVB
Copy link

@AristideVB AristideVB commented Oct 3, 2024

Description:

This pull request updates the FirebaseMessaging dependency in the v2 branch of the Customer.io iOS SDK to ensure compatibility with Firebase versions up to but not including 12.0.0.

Reason for the Update:

  • The Customer.io Flutter plugin currently depends on the v2 iOS SDK and has not yet been updated to support the v3 iOS SDK.
  • To avoid waiting for the Flutter plugin to be updated, we need to ensure that the v2 iOS SDK remains compatible with the latest Firebase versions, those latest Firebase versions include fixes for building with Xcode 16.

Impact:

  • This update ensures that projects using the Customer.io Flutter plugin (and thus the v2 iOS SDK) can build successfully with the latest versions of Firebase and thus with Xcode 16.
  • The update preserves compatibility with existing functionality in the v2.x SDK, while allowing newer Firebase versions to be used.

Updated the range to >8.7.0 <12.0.0 and tested on UIKit and CocoaPod sample apps. There are no major breaking changes as per the official Firebase document that affects this SDK.

Closes #823


  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After code reviews are approved and you determine this PR is ready to merge, select Squash and Merge button on this screen, leave the title and description to the default values, then merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant