-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gem enforces ancient version of HTTPparty #38
Comments
This dependency does suck, and I agree that old Rubies shouldn't need to be supported with future gem releases. Upgrading dependencies is scary though, especially when they don't care about semver. I think the best solution is to remove the HTTParty dependency altogether. Wrapping net/http to provide the If you want to take a run at it, I'd be happy to review & test the PR. Otherwise I'll give it a shot when I get the time. |
@dalyons We've now released a version of the gem which does not depend on HTTParty at all. We've tested this internally as much as possible. Please give it a try and let us know if you hit any problems: https://rubygems.org/gems/customerio/versions/1.0.0 |
Guys,
The pinning of HTTParty introduced in: 9552435
is pretty uncool. HTTParty is a common lib used by lots of other gems, and forcing it to an old version which globally restricts your projects usage of httpparty across all gems.
IMHO, 1.8.7 compatibility (which seems what this restriction was implemented for) is not worth it at all. 1.8.7 was EOL'd in 2012, and stopped receiving security updates in 2013. Those few people stuck on 1.8.7 would be best served with a tagged
1_8_7_stable
branch or some such.https://www.ruby-lang.org/en/news/2011/10/06/plans-for-1-8-7/
The text was updated successfully, but these errors were encountered: