Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #14

Merged
merged 16 commits into from
Jan 4, 2024
Merged

Add tests #14

merged 16 commits into from
Jan 4, 2024

Conversation

kevinkucharczyk
Copy link
Collaborator

@kevinkucharczyk kevinkucharczyk commented Jan 3, 2024

This PR accomplishes the following:

  1. Fixes ember-try scenarios breaking due to dependencies not matching (https://discord.com/channels/480462759797063690/1049716681225797723/1049738716635205772)
  2. Adds a few basic tests
  3. Updates a few packages and type definitions.
    • I had some issues where Glint's TypeScript override for the render @ember/test-helpers function wasn't being picked up by my local environment. After updating some packages, the problem is gone

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 39c5c91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-provide-consume-context Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinkucharczyk kevinkucharczyk marked this pull request as ready for review January 4, 2024 01:55
@kevinkucharczyk kevinkucharczyk merged commit f59c432 into main Jan 4, 2024
8 of 9 checks passed
@kevinkucharczyk kevinkucharczyk deleted the fix-add-tests branch January 4, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant