-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harmonicFunction. maps between RN figures and function labels #1130
Conversation
Thanks for the contribution Mark -- I think I really do want them to be Enums -- we're moving that way throughout the system. They can have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and requested changes before looking more closely at the code.
The code should also use English where possible. Only in a few cases where there is no commonly used English equivalent ("Hauptstimme", "Augenmusik") should German or French ("jetté") be used. Italian is sort of grandfathered in...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark, I left a few comments. Myke may be hoping to merge #1298 before this, so there might be a mypy tweak to do when that's in.
Thanks. Great work. |
Resolves #1103