Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonicFunction. maps between RN figures and function labels #1130

Merged
merged 11 commits into from
May 13, 2022

Conversation

MarkGotham
Copy link
Contributor

@MarkGotham MarkGotham commented Sep 16, 2021

Resolves #1103

@coveralls
Copy link

coveralls commented Sep 16, 2021

Coverage Status

Coverage increased (+0.004%) to 93.1% when pulling 7741097 on MarkGotham:harmonicFunction into 33b37c4 on cuthbertLab:master.

@MarkGotham
Copy link
Contributor Author

#1103

@mscuthbert
Copy link
Member

Thanks for the contribution Mark -- I think I really do want them to be Enums -- we're moving that way throughout the system. They can have a str() form that turns them into the labels here, but I'm trying to create more ways that people can see what the possible choices are and what they mean. Sort of like we did with the various #6, #7 Enums in RomanText.

Copy link
Member

@mscuthbert mscuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and requested changes before looking more closely at the code.

The code should also use English where possible. Only in a few cases where there is no commonly used English equivalent ("Hauptstimme", "Augenmusik") should German or French ("jetté") be used. Italian is sort of grandfathered in...

music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark, I left a few comments. Myke may be hoping to merge #1298 before this, so there might be a mypy tweak to do when that's in.

music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Outdated Show resolved Hide resolved
music21/analysis/harmonicFunction.py Show resolved Hide resolved
@mscuthbert mscuthbert merged commit f351234 into cuthbertLab:master May 13, 2022
@mscuthbert
Copy link
Member

Thanks. Great work.

@MarkGotham MarkGotham deleted the harmonicFunction branch May 14, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmony: map between function and figure
4 participants