Accidentals never and if-absolutely-necessary #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobtylerwalls would you have a chance to review this? Thanks! |
music21/pitch.py
Outdated
Comment on lines
4764
to
4768
| # nope, no previous pitches in this octave and register, now more complex things... | ||
| # but first handle 'if-absolutely-necessary' case. | ||
| if acc and acc.displayType == 'if-absolutely-necessary': | ||
| acc.displayStatus = False | ||
| return |
There was a problem hiding this comment.
I think this is too early to short-circuit, if if-absolutely-necessary also needs to show a necessary natural contradicting the ks. If it's not what it's supposed to do, then maybe reword only-for-cancelling-in-register? (not that I love that phrasing). Just that cancelling a ks seems absolutely necessary.
pr:
>>> m = stream.Measure([key.Key('C-'), note.Note('G#'), note.Note('Cn')])
>>> p = stream.Part(m)
>>> m.notes[-1].pitch.accidental.displayType = 'if-absolutely-necessary'
>>> p.show()
Maybe this means organizing the cases differently so we can short-circuit somewhere.
There was a problem hiding this comment.
Ah -- you are absolutely right. Okay, that will take a bit more time to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more logic for makeAccidentals for displayType "never"
Add "if-absolutely-necessary" displayType
Simplify some parts of the accidental making.
Do not merge until I have a chance to write tests.
(Ignore branch name -- did not get to it in this PR)