Add makeNotation routines for completing or consolidating tuplets #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
force-pushed
the
reexpress-tuplets
branch
from
5302538 to
54e8876
Compare
mscuthbert
reviewed
Aug 6, 2022
Comment on lines
+1880
to
+1882
| >>> splitElementsToCompleteTuplets(s) | ||
| >>> [el.quarterLength for el in s.notes] | ||
| [Fraction(1, 3), Fraction(2, 3), Fraction(1, 3), Fraction(2, 3)] |
There was a problem hiding this comment.
can we have a test that the second and third notes are tied?
|
If the tie adding test is added, this is ready to go and merge once tests pass. THANKS! |
|
Congrats @jacobtylerwalls -- huge amount of work. |
This was referenced Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #904
@gregchapman-dev , please share your findings if you give this a look -- you'll need makeNotation=True turned on during musicxml export, or else need to make your own calls to these new makeNotation-y routines. You might also want #1240, so a local branch merging all of that in might be the ticket. (#1240 avoids making the implausible tuplet, and then after running splitAtDurations() to get those 11 components isolated (again... another makeNotation-y routine to run yourself), this PR puts them back together in threes to get quarter rests again.)
This still doesn't get you a leading half rest -- for that, you'll want #992. Maybe @MarkGotham can reignite the effort there: I recall we were close, we solved the beat sequence extraction and just needed a PR to nail down the API, I think (?)