Fix MIDI in Google Colab Notebooks (v8) #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jupyter Notebook comes with the require.js script for loading other modules already included. Google Colab does not. Showing MIDI in the notebook needs to have require.js around. Google Colab runs each cell in its own WebWorker; thus the loading of require.js and music21j must happen in each cell -- no global variables. Since Google Colab is still running Python 3.7 (and selecting another core is a PAIN!) and music21 v8 will be 3.8+ only, this functionality is being backported to v7 and a 7.3.2 version will be released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter Notebook comes with the require.js script for loading other modules already included. Google Colab does not. Showing MIDI in the notebook needs to have require.js around. Google Colab runs each cell in its own WebWorker; thus the loading of require.js and music21j must happen in each cell -- no global variables.