Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: makeRests(inPlace=True) returns None for scores #1288

Merged
merged 1 commit into from
May 5, 2022

Conversation

jacobtylerwalls
Copy link
Member

Let makeRests(inPlace=True) return None for consistency with other methods (and with itself).

@coveralls
Copy link

coveralls commented May 1, 2022

Coverage Status

Coverage decreased (-0.001%) to 93.261% when pulling c081f61 on v8-makeRests-return into 5381ab6 on master.

@mscuthbert mscuthbert merged commit c838856 into master May 5, 2022
@mscuthbert
Copy link
Member

@jacobtylerwalls -- i've debated making inPlace just return the same thing as not inPlace in v8 because it'd help the typing a lot. BUT I don't like what it does to the doctests.

@jacobtylerwalls jacobtylerwalls deleted the v8-makeRests-return branch May 5, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants