StreamCore is now a Music21Object; Iterator improvements #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was for typing reasons. But it seems that we need another approach. Stream will need to derive from StreamCore -- a base.Music21Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typed Python does not work well with Mixin classes. There's little harm to making StreamCore a Music21Object, so it is now.
Other changes:
Attempt to unify
__getitem__on Stream and StreamIterator. For v8, a bare string w/o a dot or other query mark is discouraged, since in v7 it does different things on Streams (getElementSByClass) and on StreamIterators (getElementSINGULARById). In v9, these two types of calls will be unified into the same syntax.