Closing too many states should be a TNException #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this raised an IndexError whether or not raiseExceptions was True. Now does the best it can if raiseExceptions is False and raises a TinyNotationException if raiseExceptions is True Also improved docs of Converter process and added more typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this raised an IndexError whether or not raiseExceptions was True. Now does the best it can if raiseExceptions is False and raises a TinyNotationException if raiseExceptions is True
Also improved docs of Converter process and added more typing.
Remove weakref wrapping from a misunderstanding from before Py2.5 that circular references will not be cleaned up. We're moving away from handling weakref garbage collection and letting Py's C-language more efficient garbage collector clean them up. Tradeoff -- a little more temporary memory usage when parsing for faster parses.