Fixes bug in repeat tests in romanText/translate.py; handles empty measures #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mscuthbert
requested changes
Sep 22, 2022
mscuthbert
reviewed
Sep 22, 2022
| appendMeasureToRepeatEndingsDict(self.lastMeasureToken, | ||
| mFill, | ||
| self.repeatEndings, i) | ||
| p.coreAppend(mFill) | ||
| self.lastMeasureNumber = measureToken.number[0] - 1 | ||
| self.lastMeasureToken = measureToken | ||
|
|
||
| def fillMeasureFromPreviousRn(self, mFill: stream.Measure) -> None: | ||
| if self.previousRn is not None: |
There was a problem hiding this comment.
this is fine. but there's an easy refactor to avoid nesting.
if self.previousRn is None:
return
mscuthbert
reviewed
Sep 22, 2022
Comment on lines
+1701
to
+1704
| # mypy complains about the next line because | ||
| # RecursiveIterator.first() has t.Optional type, but we know | ||
| # it will not be None because we have just asserted that rn_iter | ||
| # has length 1 |
mscuthbert
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on addressing #1412 I noticed that there was a syntax error in the romanText in
testRepeats(my bad!). Each measure number was followed by a colon (i.e., "m1:" rather than "m1"). The first thing this PR fixes is removing those colons.The colons caused the parser to insert a note in each measure. When I removed them, I discovered that the test was actually failing on measures that are empty except for forward/backward repeat bars. To fix this required two things:
I also added a new test for the copying of empty measures.