Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve multiple fingerings on chords in musicxml import #1475

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Preserve multiple fingerings on chords in musicxml import #1475

merged 1 commit into from
Nov 2, 2022

Conversation

jacobtylerwalls
Copy link
Member

Fixes #1473

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0005%) to 93.074% when pulling 7fc1b61 on jacobtylerwalls:multiple-chord-fingerings into d77f405 on cuthbertLab:master.

@mscuthbert mscuthbert merged commit 6c1e570 into cuthbertLab:master Nov 2, 2022
@mscuthbert
Copy link
Member

Thanks for diagnosing and fixing @jacobtylerwalls

@jacobtylerwalls jacobtylerwalls changed the title Preserve multiple articulations on chords in musicxml import Preserve multiple fingerings on chords in musicxml import Nov 2, 2022
@jacobtylerwalls jacobtylerwalls deleted the multiple-chord-fingerings branch November 2, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression issue - unable get fingering of cords after parsing xml file
3 participants
@jacobtylerwalls @coveralls @mscuthbert