Cache result of findGaps() on gapless streams #1515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach uses False to distinguish "no gaps" from "force a cache miss" (None), although this has to then be converted back to None for cache hits.
An alternative would be to rewrite the cache (there aren't that many keys) to just delete keys when intending to force cache misses.
Another alternative would be to break BC and have findGaps() return something else, like an empty stream that would still test False.
Closes #1514