Improve measure numbers on ClercqTemperley #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de Clercq / Temperley files were being exported with all measure numbers set to 0. Now they are properly numbered. Deprecate `toScore` in CT parsing, add `toPart` since the format currently returns a Part object. (this should be changed to a Score object instead to fit w/ RomanText parsing, but not done now). Typing improvements for the converter.
Rewrite nasty nested routine using object attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de Clercq / Temperley files were being imported with all measure numbers set to 0. Now they are properly numbered.
Deprecate
toScorein CT parsing, addtoPartsince the format currently returns a Part object. (this should be changed to a Score object instead to fit w/ RomanText parsing, but not done now).Typing improvements for the converter.