Increase default MIDI ticksPerQuarter #1577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to comments in the code, the default MIDI
ticksPerQuarter
is set to 1024 to avoid a limitation in midi.py, which is no longer used.Therefore, I propose to set the
ticksPerQuarter
to10080
which is the same value used for MusicXML divisions. This would allow exported MIDI to represent more durations exactly without quantization errors and without significant risk/downsides.I have also updated all relevant tests.
Let me know what you think!