Jupyter: Lab compatibility & Display all pages, refactor MuseScore #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor out Jupyter code to the ipython21 directory Refactor out MuseScore code to converter/museScore Make subConverter consistently have a capital C (backwards incompatible)
mscuthbert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of Jupyter and MuseScore will now see all pages of a score when .show() is called in Jupyter.
Also adds compatibility for Jupyter Notebook v7 beta and I believe JupyterLab.
with
.show(multipageWidget=True)an interactive widget to view multiple pages appears. I thought this was going to be the default, but it turns out I much prefer just setting all pages.Many Converter commands are now staticmethods
subConverter now consistently spelled with capital C (backwards incompatible)
museScore functions moved to converter/museScore -- now can be run separate from export!
Jupyter functionality mostly moved to ipython21 where it belongs.