speed up sortTuple for streams #1624
Conversation
This avoids the computation of the duration attribute when creating a stream's `sortTuple`, which is expensive as it requires iterating over all elements to compute `highestTime`.
|
Yes! This is significant! I had the idea at some point of a GraceStream which was a stream entirely of grace notes for things like complex ornaments that have beams and their own accent patterns etc which take up zero conceptual time. But I don't think I ever implemented that and if I did then we can add a special case. Streams are one of the few subclasses of Music21Object that the base class is allowed to be aware of (that and Spanner) so putting this code in the main class is okay. I'll merge but please note that i'm less of a fan of "x = 1 if ...compound-tests-that-are-long... else 0" type of expressions rather than the simple if x: ... else: ... type. I try to avoid them except in generators/comprehensions/lambdas. And even then only if the normal case is left of the if. |
|
I’ll keep that in mind for future PRs! |
This avoids the computation of the duration attribute when creating a stream's
sortTuple, which is expensive as it requires iterating over all elements to computehighestTime.Yields significant speedups on tasks that require sorting (12% overall for a simple load + quantize benchmark on my machine).