SoundParser to a separate file #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going in the opposite direction as #1599 -- move MusicXML `<sound>` tag parsing to a separate file along with several helpers to helpers.py -- both m21ToXML and xmlToM21 are getting huge! so anything to try to make these files more manageable is the right direction. While fixing mypy errors, noticed a bunch of warnings that things that were typed were not being checked in noteworthy/binaryTranslate.py -- checked these and fixed. (TODO: make the contents of untyped functions are not checked become an error in CI)
Closed
|
Maybe |
It's something to do with changing status of I don't really want them checked until the call has a type also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going in the opposite direction as #1599 -- move MusicXML
<sound>tag parsing to a separate file along with several helpers to helpers.py -- both m21ToXML and xmlToM21 are getting huge! so anything to try to make these files more manageable is the right direction.While fixing mypy errors, noticed a bunch of warnings that things that were typed were not being checked in noteworthy/binaryTranslate.py -- checked these and fixed. (TODO: make the contents of untyped functions are not checked become an error in CI)