Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed color of 'Create object URL' on not saved object #8752

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 28, 2024

Motivation and context

This button should be gray if disabled:
Before:
image

After:
image

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Bug Fixes

    • Resolved a color inconsistency for the 'Create object URL' button when the object is unsaved.
  • Style

    • Enhanced button color specificity in the objects sidebar for better user interaction.
    • Adjusted padding, margins, and background colors for improved layout and visual hierarchy in sidebar components.
    • Maintained and slightly modified hover effects for certain sidebar elements.

@bsekachev bsekachev requested a review from nmanovic as a code owner November 28, 2024 11:18
Copy link
Contributor

coderabbitai bot commented Nov 28, 2024

Walkthrough

The changes in this pull request include a fix for the color of the 'Create object URL' button in the CVAT UI, specifically when the object has not been saved on the server. Additionally, modifications to the SCSS styles for the objects-side-bar have been made, including enhancements to button color specificity, padding, margins, and background colors of various elements. These adjustments aim to improve the visual presentation and user interaction within the sidebar components.

Changes

File Change Summary
changelog.d/20241128_131448_sekachev.bs_fixed_create_obj_url_color.md Fix for the color of the 'Create object URL' button when the object is unsaved.
cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/styles.scss Modifications to SCSS styles for button color specificity, padding, margins, and background colors in the sidebar.

Poem

In the sidebar where colors play,
A button shines, bright as day.
With padding snug and margins neat,
Interaction now feels quite sweet.
So hop along, let's celebrate,
A UI change that's truly great! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/styles.scss (1)

405-408: LGTM! Consider using a CSS custom property for better maintainability.

The implementation correctly addresses the button color issue by applying the text color only to non-disabled buttons. This is a clean solution that aligns with the PR objective.

Consider using a CSS custom property for the disabled state color to make it more maintainable:

 button {
   &:not(:disabled) {
     color: $text-color;
   }
+  &:disabled {
+    color: var(--disabled-text-color, #d9d9d9);
+  }
 }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4f7391d and a70b187.

📒 Files selected for processing (2)
  • changelog.d/20241128_131448_sekachev.bs_fixed_create_obj_url_color.md (1 hunks)
  • cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/styles.scss (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • changelog.d/20241128_131448_sekachev.bs_fixed_create_obj_url_color.md

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.04%. Comparing base (7d0205b) to head (a70b187).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8752      +/-   ##
===========================================
- Coverage    74.05%   74.04%   -0.01%     
===========================================
  Files          409      409              
  Lines        43783    43784       +1     
  Branches      3984     3984              
===========================================
- Hits         32425    32422       -3     
- Misses       11358    11362       +4     
Components Coverage Δ
cvat-ui 78.35% <ø> (-0.02%) ⬇️
cvat-server 70.34% <100.00%> (+<0.01%) ⬆️

@bsekachev bsekachev merged commit 73cdceb into develop Dec 2, 2024
33 checks passed
@bsekachev bsekachev deleted the bs/fixed_create_obj_url_color branch December 3, 2024 06:25
@cvat-bot cvat-bot bot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants