-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed color of 'Create object URL' on not saved object #8752
Conversation
WalkthroughThe changes in this pull request include a fix for the color of the 'Create object URL' button in the CVAT UI, specifically when the object has not been saved on the server. Additionally, modifications to the SCSS styles for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/styles.scss (1)
405-408
: LGTM! Consider using a CSS custom property for better maintainability.The implementation correctly addresses the button color issue by applying the text color only to non-disabled buttons. This is a clean solution that aligns with the PR objective.
Consider using a CSS custom property for the disabled state color to make it more maintainable:
button { &:not(:disabled) { color: $text-color; } + &:disabled { + color: var(--disabled-text-color, #d9d9d9); + } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
changelog.d/20241128_131448_sekachev.bs_fixed_create_obj_url_color.md
(1 hunks)cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/styles.scss
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- changelog.d/20241128_131448_sekachev.bs_fixed_create_obj_url_color.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8752 +/- ##
===========================================
- Coverage 74.05% 74.04% -0.01%
===========================================
Files 409 409
Lines 43783 43784 +1
Branches 3984 3984
===========================================
- Hits 32425 32422 -3
- Misses 11358 11362 +4
|
Motivation and context
This button should be gray if disabled:
Before:
After:
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
Style