-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to confirm correct UI and cache state after frame deletion #8949
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8949 +/- ##
===========================================
+ Coverage 73.83% 73.90% +0.06%
===========================================
Files 417 417
Lines 44602 44598 -4
Branches 4031 4031
===========================================
+ Hits 32934 32958 +24
+ Misses 11668 11640 -28
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we wont be using year in headers anymore.
LGTM
tests/cypress/support/commands.js
Outdated
}); | ||
}); | ||
|
||
Cypress.Commands.add('clickSave', (force = false) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will suggest being more specific here in naming if we add global Cypress command.
We probably have many Save
buttons across the application.
So, maybe clickSaveAnnotationView
.
Additionally I will ask to search by contains('Save').click
over the tests and replace findings
I found at least two more places with this code (case 92, case 91):
cy.get('button').contains('Save').click();
cy.get('button').contains('Save').trigger('mouseout');
Co-authored-by: Kirill Lakhov <kirill.lakhov@cvat.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Motivation and context
Fix #8872 dealt with incorrect states of UI and cache after frame deletion. The frame was not being deleted and the cache was not updated properly to reflect the changes.
How has this been tested?
Set up
cvat.config.jobMetaDataReloadPeriod
value fromcvat-core/src/config.ts
jobMetaDataReloadPeriod
to a small value (100 ms) for the sake of easier testingTest suite
GET /data/meta
is sent and that the response has frames in it.frameNum
frameNum + 1
(the next frame in the dataset)PATCH
to/data/meta
.deleted_frames
property, that it's anArray
and that it contains the deleted frame numberframeNum
deleted_frames
array contains one element:frameNum
Tear down
jobMetaDataReloadPeriod
back to the saved default valueChecklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.