Consensus simple merging #8953
Open
Consensus simple merging #8953
+10,265
−1,126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
requested review from
azhavoro,
bsekachev and
Marishka17
as code owners
klakhov
reviewed
Feb 5, 2025
cvat-ui/src/components/consensus-management-page/consensus-management-page.tsx
Outdated
Show resolved
Hide resolved
SpecLad
reviewed
Feb 7, 2025
supervisord/worker.consensus.conf
Outdated
There was a problem hiding this comment.
Do we really need another worker for this? Can't an existing worker, like the quality report worker, handle this?
| schema: | ||
| type: string | ||
| description: | | ||
| The consensus merge request id. Can be specified to check operation status. |
There was a problem hiding this comment.
We should be using the request API for status checking.
|
|
||
| @property | ||
| def organization_id(self): | ||
| return getattr(self.task.organization, "id", None) |
There was a problem hiding this comment.
Suggested change
| return getattr(self.task.organization, "id", None) | |
| return self.task.organization_id |
| @@ -453,7 +453,7 @@ def get_tmp_dirname(self) -> str: | |||
|
|
|||
|
|
|||
| @transaction.atomic(savepoint=False) | |||
| def clear_annotations_in_jobs(job_ids): | |||
| def clear_annotations_in_jobs(job_ids: Iterable[int] | Iterator[int]): | |||
There was a problem hiding this comment.
Iterator is a subclass of Iterable, so this is equivalent to Iterable[int].
| @@ -14,7 +14,7 @@ | |||
| from collections.abc import Collection, Sequence | |||
| from enum import Enum | |||
| from functools import cached_property | |||
| from typing import Any, ClassVar, Optional | |||
| from typing import Any, ClassVar, Iterable, Iterator, Optional | |||
There was a problem hiding this comment.
Please use collections.abc.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Depends on #8939, #9026
A part of #8434
consensusRQ queue and workerLimitations:
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.