Move the COLMAP .bin files to the top level SfM directory #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sarlinpe
pushed a commit
that referenced
this pull request
Jul 17, 2021
- **[BREAKING]** improved structure of the SfM folders (triangulation and reconstruction), see [#76](#76) - Support for image retrieval (NetVLAD, DIR) and more local features (SIFT, R2D2) - Support for more datasets: Aachen v1.1, Extended CMU Seasons, RobotCar Seasons, 4Seasons, Cambridge Landmarks, 7-Scenes - Simplified pipeline and API - Spatial matcher - Support for arbitrary paths of features and matches - Support for matching multiple feature files together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the triangulation creates COLMAP files in
$sfm_dir/model/and the reconstruction in$sfm_dir/models/0/. This PR moves the final SfM files to$sfm_dir. This simplifies the top-level code and improves its clarity, but certainly breaks existing pipelines, although this can be very easily fixed. Without a better solution, I will merge this PR into dev.