Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new solvers is extremely difficult #22

Closed
leogrillo opened this issue Jun 27, 2023 · 2 comments
Closed

Adding new solvers is extremely difficult #22

leogrillo opened this issue Jun 27, 2023 · 2 comments

Comments

@leogrillo
Copy link

Thank you for developing this software, it is extremely interesting and fast.
One issue which I found was that if someone wants to add a new solver, the process is extremely difficult. You have to manually add to the elif statements in the generate_code function of the cpg script, and in the utils script. This is over 2400 lines of code, and is a long process.
It would be great if adding a new solver would be an easier process, and if more solvers would be supported.

Thank you!!!
Leo

@SteveDiamond
Copy link
Member

Hi Leo! Agreed it is challenging to add new solvers. I think there are two paths forward that can be pursued in parallel:

  1. Refactor the existing code.
  2. Develop a generic solver interface so every new solver isn't so bespoke.

@maxschaller
Copy link
Collaborator

See #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants