Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sine basis #5

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Sine basis #5

merged 10 commits into from
Feb 29, 2024

Conversation

AramisDuf
Copy link
Collaborator

Fixing bugs in trend and in "multiplying" custom basis. Inmplementing the standing wave basis.

src/spcqe/functions.py Outdated Show resolved Hide resolved
src/spcqe/functions.py Outdated Show resolved Hide resolved
src/spcqe/functions.py Outdated Show resolved Hide resolved
src/spcqe/functions.py Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@AramisDuf AramisDuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the code review with Bennet

@bmeyers bmeyers self-requested a review February 22, 2024 23:38
@bmeyers bmeyers self-assigned this Feb 22, 2024
Copy link
Member

@bmeyers bmeyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after comments above addressed

@AramisDuf
Copy link
Collaborator Author

Resolved all the comments

src/spcqe/functions.py Show resolved Hide resolved
src/spcqe/functions.py Outdated Show resolved Hide resolved
src/spcqe/functions.py Outdated Show resolved Hide resolved
@AramisDuf AramisDuf merged commit 29c7266 into main Feb 29, 2024
@AramisDuf AramisDuf deleted the sine_basis branch February 29, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants