Convert snake case setters to camel case. #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this one because it doesn't meet PEAR standards |
|
You can still use |
cweiske
pushed a commit
that referenced
this pull request
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way library was looking for setter methods.
Previously it was concatenating 'set' with ucfirst($name). This way, if the incoming json had an attribute written in snake case like "number_of_comments", it'd look for a method called setNumber_of_comments, which does not follow the PSR-1 convention.
With this change, it now converts the name of the json attribute to camel case, and looks for the correct setter method.