Depend on abstractions in the repository behaviour #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the method signature in the repository behaviour to depend on the
\A17\Twill\Models\Contracts\TwillModelContractabstraction instead of the concrete implementation. ie.\A17\Twill\Models\ModelThis makes it easier to use metadata on objects which are not directly managed trough twill, but still serve as the basis for metadata and other related entities.
In addition I've made some small modifications to the usage of classes within the
HasMetadatatrait. These changes don't really change anything in the way PHP resolves these classes, but it primarily makes it simpler to click trough them in an IDE.