Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused or Unnecessary files/variables are present which can lead to errors and security issues #82

Closed
1 of 3 tasks
bnasslahsen opened this issue Apr 6, 2023 · 0 comments · Fixed by #83
Closed
1 of 3 tasks

Comments

@bnasslahsen
Copy link
Contributor

bnasslahsen commented Apr 6, 2023

Summary

The project contains unnecessary resources, that needs to be cleaned up.
These unnecessary resources, covers:

  • Unused files: HTML files / properties files
  • Unused code/variables / libraries

Steps to Reproduce

  1. Go to 'src/main/resources' folder
  2. Check the existence of:
  • hello.html
  • application.properties:
    • Contains spring.main.allow-bean-definition-overriding=true which may lead to Breaking existing functionality/ to Confusing code / Maintenance issues / Testing challenges
  • conjur.properties

check in the pom.xml:

<dependency>
	<groupId>javax.xml.bind</groupId>
	<artifactId>jaxb-api</artifactId>
	<version>2.3.0</version>
</dependency>
<dependency>
	<groupId>com.jayway.restassured</groupId>
	<artifactId>rest-assured</artifactId>
	<version>${rest.assured.version}</version>
	<scope>test</scope>
</dependency>

<!--This is already brought by `spring-boot-starter-test`-->
<dependency>
	<groupId>org.mockito</groupId>
	<artifactId>mockito-core</artifactId>
	<scope>test</scope>
</dependency>

Expected Results

  • The binary should be clean of any unused resource

Actual Results

  • The current version, contains Unnecessary files/variables

Reproducible

  • Always
  • Sometimes
  • Non-Reproducible

Version/Tag number

conjur-sdk-springboot version 1.0.2.

Environment setup

  • Running on macOS 13.2.1 / IntelliJ IDEA 2022.2
  • Java version: 11.0.15
  • spring-boot 2.7.10
  • conjur enterprise 12.9
@bnasslahsen bnasslahsen changed the title Non used or Unnecessary files/variables are present which can lead to errors and security issues Unused or Unnecessary files/variables are present which can lead to errors and security issues Apr 6, 2023
bnasslahsen added a commit to bnasslahsen/conjur-spring-boot-sdk that referenced this issue Apr 6, 2023
bnasslahsen added a commit to bnasslahsen/conjur-spring-boot-sdk that referenced this issue Apr 7, 2023
bnasslahsen added a commit to bnasslahsen/conjur-spring-boot-sdk that referenced this issue Apr 7, 2023
itsbrugu added a commit to bnasslahsen/conjur-spring-boot-sdk that referenced this issue Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants