Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ConjurPropertySource Not only applied to the properties of a class. #76

Merged
merged 7 commits into from
Apr 10, 2023

Conversation

bnasslahsen
Copy link
Contributor

@bnasslahsen bnasslahsen commented Apr 6, 2023

closes #75

Desired Outcome

  • Only a single call should be made to the conjur API for retrieving a secret

Implemented Changes

  • Filtering on properties to make sure, Conjur REST API calls are made only to properties annotated with ConjurPropertySource
  • Replace new SecretsApi by SecretsApi spring bean injection to improve testability of the code
  • Replaced empty catch exception block, with logger for better troubleshooting in cases of errors.

Startup time:

Before the fix:
Pasted Graphic 2
After the fix:
Pasted Graphic 6

Conjur REST API CALLs

Before the fix:
Pasted Graphic 3
After the fix:
Pasted Graphic 5

Connected Issue/Story

Resolves #75

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@itsbrugu itsbrugu requested review from nitincyberark, asaraogi, jaleela-f and sukanti2210 and removed request for asaraogi April 6, 2023 18:00
Copy link
Contributor

@jaleela-f jaleela-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed .Seems to be okay

@itsbrugu itsbrugu merged commit 3f2c830 into cyberark:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@ConjurPropertySource Not only applied to the properties of a class.
4 participants