Use database query to filter role memberships by type #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously each membership role was queried individually from the database to check its "kind" and find the layers. This led to massive performance degredation with a large number of memberships, as is the case with a host factory creating many (100s) of hosts. This commit implements that filter entirely in SQL to avoid the round trips and improve performance at scale.
|
Code Climate has analyzed commit f953498 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.6% (0.0% change). View more on Code Climate. |
nessiLahav
approved these changes
Jun 10, 2020
|
Thanks @nessiLahav, I'd love to actually see your before and after numbers. I was testing this with a cucumber scenario that loaded 4000 hosts. After this, it completes in 5 minutes (with all of the setup and debug logging), but I couldn't get a before number because it would crash before finishing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously each membership role was queried individually from the database to
check its "kind" and find the layers. This led to massive performance degredation
with a large number of memberships, as is the case with a host factory creating
many (100s) of hosts.
This PR implements that filter entirely in SQL to avoid the round trips and
improve performance at scale.
What ticket does this PR close?
Connected to #1605
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs