Body parser now raises proper error on invalid request body #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telday
force-pushed
the
request-body-fix
branch
from
f25a7e1
to
f08d6a8
Compare
telday
force-pushed
the
request-body-fix
branch
from
f08d6a8
to
6afa28c
Compare
Fixes issues where 500 error was raised when application/json Content-Type header was specified with empty request body
telday
force-pushed
the
request-body-fix
branch
from
6afa28c
to
d3956cb
Compare
|
Code Climate has analyzed commit d3956cb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 75.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.4%. View more on Code Climate. |
micahlee
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where 500 error was raised when application/json
Content-Type header was specified with empty or malformed request body
What does this PR do?
Adds error handling for malformed JSON body in request which will nicely catch the error then return a 400 error code rather than a 500 error.
What ticket does this PR close?
Resolves #1968
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or