Onyx 9442 integration #2387
Merged
Onyx 9442 integration #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avi-Eyal
force-pushed
the
onyx-9442-integration
branch
from
6629405
to
2c81a90
Compare
sashaCher
force-pushed
the
onyx-9442-integration
branch
from
2c81a90
to
6208483
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| sh ./get_tokens_to_files.sh "$gcp_func_url" "$token_prefix" || exit 1 | ||
| cd - | ||
| local decoded_gcf_token_payload=$(_get_gcp_token_payload "../ci/authn-gcp/tokens/gcf_token_valid") | ||
| local decoded_gcf_token_payload=$(_get_gcp_token_payload "../ci/test_suites/authenticators_gcp/tokens/gcf_token_valid") |
There was a problem hiding this comment.
Declare and assign separately to avoid masking return values.
| local gce_instance_name="$(echo "$decoded_gce_token_payload" | jq -r '.google.compute_engine.instance_name')" | ||
| local gce_service_account_id="$(echo "$decoded_gce_token_payload" | jq -r '.sub')" | ||
| local gce_service_account_email="$(echo "$decoded_gce_token_payload" | jq -r '.email')" | ||
| local gce_project_id="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.google.compute_engine.project_id')" |
There was a problem hiding this comment.
Declare and assign separately to avoid masking return values.
| local gce_service_account_id="$(echo "$decoded_gce_token_payload" | jq -r '.sub')" | ||
| local gce_service_account_email="$(echo "$decoded_gce_token_payload" | jq -r '.email')" | ||
| local gce_project_id="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.google.compute_engine.project_id')" | ||
| local gce_instance_name="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.google.compute_engine.instance_name')" |
There was a problem hiding this comment.
Declare and assign separately to avoid masking return values.
| local gce_project_id="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.google.compute_engine.project_id')" | ||
| local gce_instance_name="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.google.compute_engine.instance_name')" | ||
| local gce_service_account_id="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.sub')" | ||
| local gce_service_account_email="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.email')" |
There was a problem hiding this comment.
Declare and assign separately to avoid masking return values.
| local gce_service_account_email="$(echo "$decoded_gce_token_payload" | jq -r '.email')" | ||
| local gce_project_id="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.google.compute_engine.project_id')" | ||
| local gce_instance_name="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.google.compute_engine.instance_name')" | ||
| local gce_service_account_id="$(echo "$DECODED_GCP_TOKEN_PAYLOAD" | jq -r '.sub')" |
There was a problem hiding this comment.
Declare and assign separately to avoid masking return values.
|
Code Climate has analyzed commit 6208483 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What ticket does this PR close?
ONYX-9442
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, orAPI Changes