-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle error HTTP codes when fetching jwks data #2474
Conversation
5075e08
to
8bc72f9
Compare
Co-authored-by: Shuli Finkelstein <64148158+shulifink@users.noreply.github.com>
7379478
to
ae35588
Compare
Code Climate has analyzed commit ae35588 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 91.2% (0.1% change). View more on Code Climate. |
@@ -33,6 +33,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
[#2447](https://github.com/cyberark/conjur/pull/2447) | |||
[#2437](https://github.com/cyberark/conjur/pull/2437)) | |||
|
|||
### Changed | |||
- Proper error message appears when JWT Authenticator gets HTTP code error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lists should be surrounded by blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Desired Outcome
A proper error message appears when JWKS GET request result is not success (HTTP code is not 200)
Implemented Changes
CreateJwksFromHttpResponse
class is calling Net::HTTPResponse.value method that raises a proper exception when HTTP code is not 2xx.Connected Issue/Story
ONYX-16186
Definition of Done
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security