Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rails version #2486

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Upgrade rails version #2486

merged 1 commit into from
Feb 10, 2022

Conversation

andytinkham
Copy link
Contributor

Signed-off-by: Andy Tinkham andy.tinkham@cyberark.com

Desired Outcome

Use Rails > 6.1.4.1

Implemented Changes

Upgraded rails to 6.1.4.4

@andytinkham andytinkham requested a review from a team as a code owner February 10, 2022 19:54
Signed-off-by: Andy Tinkham <andy.tinkham@cyberark.com>
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Nothing should go in this section, please add to the latest unreleased version
(and update the corresponding date), or add a new version.

### Security
- Updated Rails to 6.1.4.4 to resolve CVE-2021-44528 (Medium, Not Vulnerable)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andytinkham Mind inserting a newline before the list item to satisfy CC? ty

@codeclimate
Copy link

codeclimate bot commented Feb 10, 2022

Code Climate has analyzed commit c6cd519 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.0% (-1.2% change).

View more on Code Climate.

Copy link
Contributor

@semyon-estrin semyon-estrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants