Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Fix broken pipeline on cryptography dependency #183

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

tzheleznyak
Copy link
Contributor

@tzheleznyak tzheleznyak commented Feb 8, 2021

What does this PR do?

A bump in the cryptography indirect dependency lead to cascading breaking changes in our direct dependency pyopenssl. This PR fixes this by directing adding cryptography to our requirements.txt and reverting to a previous cryptography version.

image

New Release of cryptography version 3.4.1 broke our pipeline. Currently We will use the previous version 3.3.1 and and issue will open to investigate it future #184

For more reading about the rust problem in new cryptography version you can read in their github page : pyca/cryptography#5771

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or.
  • This PR does not require updating any documentation

@tzheleznyak tzheleznyak requested review from Tovli, sigalsax, liavyona and a team February 8, 2021 10:43
@tzheleznyak tzheleznyak self-assigned this Feb 8, 2021
Tovli
Tovli previously approved these changes Feb 8, 2021
Copy link

@Tovli Tovli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Feb 8, 2021

Code Climate has analyzed commit b55a6d2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 68.4% (0.0% change).

View more on Code Climate.

@sigalsax sigalsax changed the title Fix Broken Pipeline Fix broken pipeline on cryptography dependency Feb 8, 2021
Copy link
Contributor

@sigalsax sigalsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants