Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing dependency of libController from version.txt #6299

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fixed missing dependency of libController from version.txt #6299

merged 2 commits into from
Jul 5, 2023

Conversation

omichel
Copy link
Member

@omichel omichel commented Jul 5, 2023

Whenever version.txt changes, robot.c should be recompiled.

@omichel omichel added the bug Something isn't working label Jul 5, 2023
@omichel omichel added this to the R2023b-rev1 milestone Jul 5, 2023
@omichel omichel self-assigned this Jul 5, 2023
@omichel omichel added bug Something isn't working and removed bug Something isn't working labels Jul 5, 2023
@omichel omichel requested a review from ygoumaz July 5, 2023 14:15
@omichel omichel marked this pull request as ready for review July 5, 2023 14:15
@omichel omichel requested a review from a team as a code owner July 5, 2023 14:15
ygoumaz
ygoumaz approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@ygoumaz ygoumaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will also be useful for webots_ros2!

@omichel omichel merged commit f03f2e9 into master Jul 5, 2023
20 checks passed
@omichel omichel deleted the fix-libcontroller-dependency-on-version.txt branch July 5, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygoumaz ygoumaz ygoumaz approved these changes

Assignees

@omichel omichel

Labels
bug Something isn't working
Milestone
R2023b-rev1
Development

Successfully merging this pull request may close these issues.
2 participants
@omichel @ygoumaz